Skip to content

update ES env variable documentation #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 20, 2025
Merged

Conversation

BBrixen
Copy link
Contributor

@BBrixen BBrixen commented Jul 2, 2025

fixes incorrect or missing documentation for ES_USE_SSL, ES_VERIFY_CERTS, and ES_API_KEY

Description:

  • README.md documentation has incorrect default values for ES_USE_SSL and ES_VERIFY_CERTS
  • The default values that are used can be found at: ./stac_fastapi/elasticsearch/stac_fastapi/elasticsearch/config.py and ./stac_fastapi/opensearch/stac_fastapi/opensearch/config.py
  • Adds documentation for ES_API_KEY

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@jonhealy1 jonhealy1 self-requested a review July 20, 2025 11:54
jonhealy1
jonhealy1 previously approved these changes Jul 20, 2025
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BBrixen Nice work here. Thank you!

@jonhealy1 jonhealy1 self-requested a review July 20, 2025 12:00
@jonhealy1 jonhealy1 merged commit 970f65e into stac-utils:main Jul 20, 2025
15 checks passed
GrzegorzPustulka pushed a commit to GrzegorzPustulka/stac-fastapi-elasticsearch-opensearch that referenced this pull request Jul 21, 2025
fixes incorrect or missing documentation for ES_USE_SSL,
ES_VERIFY_CERTS, and ES_API_KEY


**Description:**
- README.md documentation has incorrect default values for ES_USE_SSL
and ES_VERIFY_CERTS
- The default values that are used can be found at:
`./stac_fastapi/elasticsearch/stac_fastapi/elasticsearch/config.py` and
`./stac_fastapi/opensearch/stac_fastapi/opensearch/config.py`
- Adds documentation for ES_API_KEY

**PR Checklist:**

- [X] Code is formatted and linted (run `pre-commit run --all-files`)
- [X] Tests pass (run `make test`)
- [X] Documentation has been updated to reflect changes, if applicable
- [X] Changes are added to the changelog

---------

Co-authored-by: Bennett Patrick Brixen <bpbrixe@sandia.gov>
Co-authored-by: Jonathan Healy <jonathan.d.healy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants